Merged
Conversation
CodSpeed Performance ReportMerging #5401 will not alter performanceComparing Summary
|
Member
|
safari doesn't support this, do we care? |
Contributor
Author
That's a Safari problem isn't it? |
masenf
approved these changes
Jun 6, 2025
Collaborator
masenf
left a comment
masenf
left a comment
There was a problem hiding this comment.
tentative approval provided docs are appropriately updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From experimentation, on_scroll is kinda spammy during scroll events, so it might be useful to have one that fire once per scroll, when it end.
It's a
no_args_event_specfor now because I didn't find much useful data inside the event that is fired on that trigger.